Thursday, September 22, 2005 3:43 AM
Checklist for Code Reviews
The following checklist contains general questions to keep in mind when reviewing code. It assumes that a design walkthrough has been conducted and that algorithm correctness has been established as part of the design review.
- Has the design properly been translated into code? (The results of the procedural design should be available during this review.)
- Are there misspellings and typos?
- Has proper use of language conventions been made?
- Is there compliance with coding standards for language style, comments, module prologue?
- Are there incorrect or ambiguous comments?
- Are comments useful or are they simply alibis for poor coding?
- Are data types and data declarations proper?
- Are physical constants correct?
- Are there redundant operations for which there is no compensating benefit?
- Has maintainability been considered?
- Completeness
- Are all referenced data defined, computed, or obtained from external source?
- Are all defined data used?
- Are all referenced subprograms defined?
- Are all defined subprograms used?
- Efficiency
- Are all non loop dependent computations kept out of loop?
- Are all compound expressions defined once?
- Are data grouped for efficient processing?
- Are data indexed and referenced for efficient processing?